Page 1 of 1

[Klonan] [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Wed Feb 27, 2019 9:25 pm
by tterrag1098
I was not able to reproduce this issue in vanilla, but enabling any one of my mods triggered it.
factorio_2019-02-27_16-00-43.jpg
factorio_2019-02-27_16-00-43.jpg (303.6 KiB) Viewed 4835 times
My scenario was set up with no victory conditions (collaborative play). Full settings:
factorio_2019-02-27_16-22-27.png
factorio_2019-02-27_16-22-27.png (66.81 KiB) Viewed 4835 times
Full text from log:

Code: Select all

  26.090 Error MainLoop.cpp:1092: Exception at tick 49320: The scenario level caused a non-recoverable error.
Please report this error to the scenario author.

Error while running event level::on_nth_tick(60)
...minecraft/factorio/server/temp/currently-playing/pvp.lua:2288: bad argument #1 to 'pairs' (table expected, got nil)
stack traceback:
        [C]: in function 'pairs'
        ...minecraft/factorio/server/temp/currently-playing/pvp.lua:2288: in function 'check_update_space_race_score'
        ...minecraft/factorio/server/temp/currently-playing/pvp.lua:3737: in function <...minecraft/factorio/server/temp/currently-playing/pvp.lua:3732
  26.090 Error ServerMultiplayerManager.cpp:92: MultiplayerManager failed: "The scenario level caused a non-recoverable error.
Please report this error to the scenario author.

Error while running event level::on_nth_tick(60)
...minecraft/factorio/server/temp/currently-playing/pvp.lua:2288: bad argument #1 to 'pairs' (table expected, got nil)
stack traceback:
        [C]: in function 'pairs'
        ...minecraft/factorio/server/temp/currently-playing/pvp.lua:2288: in function 'check_update_space_race_score'
        ...minecraft/factorio/server/temp/currently-playing/pvp.lua:3737: in function <...minecraft/factorio/server/temp/currently-playing/pvp.lua:3732>

Re: [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Wed Feb 27, 2019 9:39 pm
by IIPoliII
The problem is your lua script you have to change it for the 0.17.2 change the pvp.lua at the error showed in your print screen

Re: [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Wed Feb 27, 2019 9:57 pm
by Klonan
tterrag1098 wrote: Wed Feb 27, 2019 9:25 pm I was not able to reproduce this issue in vanilla, but enabling any one of my mods triggered it.
factorio_2019-02-27_16-00-43.jpg
Can you attach or link to one of these mods?

Re: [Klonan] [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Thu Feb 28, 2019 4:32 am
by tterrag1098
Any mod seemed to cause it, but the three I tried were I believe VehicleSnap, Bob's Inserters, and Even Distribution.

Re: [Klonan] [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Thu Feb 28, 2019 10:53 am
by Klonan
Thanks, I managed to reproduce it

It is fixed for the next release,
However old saves of the PvP scenario will still have the error present, so I would suggest to start a fresh one.

Re: [Klonan] [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Thu Feb 28, 2019 11:53 am
by Henry Loenwind
Klonan wrote: Thu Feb 28, 2019 10:53 am However old saves of the PvP scenario will still have the error present, so I would suggest to start a fresh one.
Thanks for the quick fix.

However, I know a couple of people who would throw tterrag into a biter nest if he was to reset the server now. But as we're all quite capable of going low-level, I think we should be able to manage replacing a file in the save if it's accessible. Is it just the one listed in the crash report? (Can't be harder than modding Minecraft before modloaders were a thing, can it?)

Re: [Klonan] [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Thu Feb 28, 2019 1:11 pm
by Klonan
Henry Loenwind wrote: Thu Feb 28, 2019 11:53 am But as we're all quite capable of going low-level, I think we should be able to manage replacing a file in the save if it's accessible. Is it just the one listed in the crash report? (Can't be harder than modding Minecraft before modloaders were a thing, can it?)
It is pretty simple, you will just need to extract the save, and replace `pvp.lua` with the new one in the next release

Re: [Klonan] [0.17.2] Crash when loading PvP scenario with any mods installed

Posted: Thu Feb 28, 2019 1:31 pm
by Henry Loenwind
Klonan wrote: Thu Feb 28, 2019 1:11 pm It is pretty simple, you will just need to extract the save, and replace `pvp.lua` with the new one in the next release
Thanks!!