[kovarex] [0.17.50] Crash During Auto-Save With Keypress (connection.rail->segment->hasSignal(this) was not true)

[wizard07ksu]

1. What did I do? I pressed 'Q' while mouse was hovering over an angled rail signal attached to a rail segment just after the auto-save progress bar dialog appeared.
2. What happened? The progress bar froze for several seconds, then the "game has crashed dialog" appeared.
3. What did I expect to happen? I didn't expect the game to crash just because I pressed a key during the auto-save dialog. I know that some features of the game are still enabled during auto-save (can still go through blueprints), but I would have expected all other actions to be explicitly disabled for the duration of the save.

I have only experienced this bug once.

[1cec0ld]

I suspect I'm also a victim of this one, just occurred. I wasn't paying attention to what I was doing, just know it crashed as the autosave popup began.

[boskid]

wizard07ksu log

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\entity\railsignalbase.cpp (358): RailSignalBase::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\entity\railsignalbase.cpp (67): RailSignalBase::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\entity\railsignal.cpp (50): RailSignal::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\surface\chunk.cpp (101): Chunk::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\surface\surface.cpp (765): Surface::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1339): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

4923.765 Error RailSignalBase.cpp:358: connection.rail->segment->hasSignal(this) was not true

This is something new, trains related
---
1cec0ld's log

1cec0ld log

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\railblock.cpp (302): RailBlock::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (956): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

8409.959 Error RailBlock.cpp:302: inboundSignal->getReservation() == nullptr was not true

Also trains related but different assertion failed. May be Duplicate 72006

[wizard07ksu]

Two more pieces of info:

1. Factorio created a partial save file and said it was corrupt when I next started the game. I didn't explicitly try to load it, the game auto-selected the file and told me it was corrupt via a dialog with a "Confirm" button. When I looked for that file in the saves directory just now, it wasn't there.
2. After loading the save file I did upload, I was able to play past the point where the game crashed. This map is still small enough that saves go pretty quickly - I have another, much larger base where saving takes several seconds. I can attempt to recreate the bug there if that will help?

[Mihu]

For me this had nothing to do with keypresses - see viewtopic.php?f=47&t=72733 for a simple repro (was marked as duplicate).

[kovarex]

Hello, this is most probably related to a bug already fixed for the next version.