[MOD 0.12.x] Searching flashlight

[rk84]

Type: Mod
Name: Searching flashlight
Description: Makes character turn to direction of selected entity while standing still.
License: MIT
Version: 1.0.0
Release: 2016-03-01
Tested-With-Factorio-Version: 0.12.22
Category: Other
Tags: Flashlight
Download-Url: https://github.com/rk84/searching-flashlight/releases
Website: https://github.com/rk84/searching-flashlight

License

License
The MIT License (MIT)

Copyright (c) 2013 rk84

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Pictures

Version history

Version history
Version 1.0.0 (20160301): Release

[Koub]

Wow that looks so well thought
Hope I'll have to play one day so that I can give it a try

[mngrif]

This is pretty awesome! Any idea if it breaks multiplayer? It should...

[Supercheese]

Whoah that's pretty neat!

[rk84]

This is pretty awesome! Any idea if it breaks multiplayer? It should...

It should not break in MP. The code doesn't use methods that I know to be unsupported and my 2 client test was successfull.

[dandielo]

Hey there I've just got a small bug with this mod, this occurred in a MP session, when my friend got disconnected, I've quickly checked the code and added an additional check if a player is connected.

Code: Select all

-- Changed this 
if not players[i].vehicle and players[i].selected and players[i].character and not players[i].walking_state.walking then

-- Into this
if players[i].connected and not players[i].vehicle and players[i].selected and players[i].character and not players[i].walking_state.walking then

[Taehl]

I've added this to my game-in-progress. After loading, once it begins to become night (within 30 seconds), I get this error:

Code: Select all

__searching-flashlight__/control.lua:16: Invalid direction

Also, it would be nice if your character lerped to the new angle instead of instantly snapping to it - it would look much smoother.

EDIT) I'm playing 0.12.29, in case that matters.

[rk84]

Hey there I've just got a small bug with this mod, this occurred in a MP session, when my friend got disconnected, I've quickly checked the code and added an additional check if a player is connected.

Code: Select all

-- Changed this 
if not players[i].vehicle and players[i].selected and players[i].character and not players[i].walking_state.walking then

-- Into this
if players[i].connected and not players[i].vehicle and players[i].selected and players[i].character and not players[i].walking_state.walking then

Thanks.

I've added this to my game-in-progress. After loading, once it begins to become night (within 30 seconds), I get this error:

Code: Select all

__searching-flashlight__/control.lua:16: Invalid direction

Also, it would be nice if your character lerped to the new angle instead of instantly snapping to it - it would look much smoother.

EDIT) I'm playing 0.12.29, in case that matters.

I added better clamping. Hoping it will fix that.
I can't make it smoother currently. Has only 8 directions. This must be due to nature of character entity. Walking "direction" is used over Smooth "orientation" unless in combat.

[Taehl]

What about the car and tank? They don't snap to the 8 directions. Watching their headlights sweep through the night is awesome and I want the player to do it too. Maybe there's a way to use the orientation thing instead?

[rk84]

What about the car and tank? They don't snap to the 8 directions. Watching their headlights sweep through the night is awesome and I want the player to do it too. Maybe there's a way to use the orientation thing instead?

Yes, I think that is possible, but it will add some complexity to this simple mod.

[DevilXD]

Will this mod get updated ? I'm still using it but something has broke since 0.14 version came out. It was working perfectly in the 0.13 version.

[aubergine18]

I've sent a PR which should fix it, but in interim see if this version works:

https://github.com/aubergine10/searchin ... ee/patch-1

Please leave comment in the PR indicating whether problem is fixed:

https://github.com/rk84/searching-flashlight/pull/2

[aubergine18]

The bug with player rotation is fixed in 0.14.6 viewtopic.php?t=32318

[rk84]

I added 1.1.0 to mod portal.
Thank you for help aubergine18

[aubergine18]

In your `info.json` it might be worth setting more specific factorio version to ensure the bugfix from 0.14.6 is available:

Code: Select all

"factorio_version": "0.14.7"

[DevilXD]

In your `info.json` it might be worth setting more specific factorio version to ensure the bugfix from 0.14.6 is available:

I don't think that variable works like that, rather something like this:

Code: Select all

"factorio_version": "0.14",
"dependencies": ["base >= 0.14.6"],

[rk84]

I changed the dependency version number. also removed version number from title. I assume/hope mod portal uses names as IDs.
I'm bit puzzled why ingame mod browser does not show version number, but info.json has it and mod portal site shows it.
ah must be because I run stable 0.13 and release is now only for 0.14. hmm

[GotLag]

FYI the mod doesn't work when unzipped, unless you rename the folder to "searching-flashlight_1.1.1"

Also you can streamline the code a bit:

Code: Select all

local dx = player.position.x - player.selected.position.x
local dy = player.selected.position.y - player.position.y
local orientation = (atan2(dx, dy) / pi + 1) / 2
player.character.direction = floor(orientation * 8 + 0.5) % 8

Seems to be a bit faster according to time_used_percent (~0.007 instead of ~0.009 on my computer).

[IsaacHeron]

I'd love to see this updated for 0.15.

[Nexela]

Added to picker extended in the next version

If you really want it as a stand alone let me know.