Sesame_Slayer wrote: ↑Mon Aug 29, 2022 10:30 pm
I have been trying to make a mod to either move all effects from the logistic system tech to logistic robotics, or simply remove utility science pack as both a prerequisite and needed pack, and change the count from 500 to 150, with these modes interchangeable via settings.
What type of settings are you using? This concerns the definition of prototypes, so setting_type should be "startup" instead of "runtime-global".
I get an error I had gotten before with mismatched parenthesis, but there is none, and it claims that the "earlierlogisticsmainsetting" on line 13 is the error, even though the same line is in line 2, except with "merge" instead of "changepack".
In the first block you define a function that should be called when the game is initialized. The second block overwrites that with another function. When the game starts, only the second function will be run, so naturally it won't complain about errors from the function in your first block.
If there is any other errors in the code, it would be nice to mention them, as it seems no matter what I fix, there is always a problem. Please note I am not good at modding, and the error is probably obvious.
You should read this
tutorial on modding, and you should definitely read about the
data life cycle, and when you're done, go back to start and read about the
data life cycle again and
again. If you want to start modding Factorio, that's probably the most important text you can read.
Code: Select all
script.on_init(function()
if settings.global["earlierlogisticsmainsetting"].value == "merge" then
table.insert(data.raw["technology"]["logistic-robotics"].effects, {type = "unlock-recipe",recipe = "logistic-chest-active-provider"})
table.insert(data.raw["technology"]["logistic-robotics"].effects, {type = "unlock-recipe",recipe = "logistic-chest-buffer"})
table.insert(data.raw["technology"]["logistic-robotics"].effects, {type = "unlock-recipe",recipe = "logistic-chest-requester"})
if data.raw.technology["logistic-system"] then
data.raw.technology["logistic-system"] = null
end
end
end)
The most obvious mistake here is that you want to modify prototypes during the control stage. You've defined a handler for script.on_init() -- but this doesn't exist before the control stage, while prototypes are defined in the data stage. So, put your code in data.lua, get rid of the control stage wrapper, and correct the setting type:
Code: Select all
if settings.startup["earlierlogisticsmainsetting"].value == "merge" then
table.insert(data.raw["technology"]["logistic-robotics"].effects, {type = "unlock-recipe",recipe = "logistic-chest-active-provider"})
table.insert(data.raw["technology"]["logistic-robotics"].effects, {type = "unlock-recipe",recipe = "logistic-chest-buffer"})
table.insert(data.raw["technology"]["logistic-robotics"].effects, {type = "unlock-recipe",recipe = "logistic-chest-requester"})
if data.raw.technology["logistic-system"] then
data.raw.technology["logistic-system"] = null
end
end
That's just the first step. As you've demonstrated yourself:
Code: Select all
if data.raw.technology["logistic-system"] then
data.raw.technology["logistic-system"] = null
end
mods may remove stuff that you take for granted. So why are you so sure that data.raw["technology"]["logistic-robotics"].effects really exists? You're not alone, and if somebody is playing with your mod, chances are they will have other mods loaded as well. Don't ever take anything for granted but make sure the things you want to access really exist!
Code: Select all
local my_setting = settings.startup["earlierlogisticsmainsetting"]
if my_setting and my_setting.value == "merge" then
local tech = data.raw["technology"]["logistic-robotics"]
if tech then
tech.effects = tech.effects or {}
table.insert(tech.effects, {type = "unlock-recipe",recipe = "logistic-chest-active-provider"})
table.insert(tech.effects, {type = "unlock-recipe",recipe = "logistic-chest-buffer"})
table.insert(tech.effects, {type = "unlock-recipe",recipe = "logistic-chest-requester"})
end
if data.raw.technology["logistic-system"] then
data.raw.technology["logistic-system"] = null
end
end
About "logistic-system": Don't overwrite the technology! You're not alone, other mods may expect that the technology exists and could break if you removed it! Instead, you should disable and hide it:
Code: Select all
tech = data.raw.technology["logistic-system"]
if tech then
tech.enabled = false
tech.hidden = true
end
Here's the complete code for your first setting:
Code: Select all
local my_setting = settings.startup["earlierlogisticsmainsetting"]
if my_setting and my_setting.value == "merge" then
local tech = data.raw.technology["logistic-robotics"]
if tech then
tech.effects = tech.effects or {}
table.insert(tech.effects, {type = "unlock-recipe", recipe = "logistic-chest-active-provider"})
table.insert(tech.effects, {type = "unlock-recipe", recipe = "logistic-chest-buffer"})
table.insert(tech.effects, {type = "unlock-recipe", recipe = "logistic-chest-requester"})
end
tech = data.raw.technology.["logistic-system"]
if tech then
tech.enabled = false
tech.hidden = true
end
end
I'll leave fixing the code for the second part to you as a practical exercise.
By the way, your old code for removing "logistic-system" probably contained an error:
Code: Select all
data.raw.technology["logistic-system"] = null
There is no such thing as "null" in Lua, it's called "nil". Nevertheless, this would have worked incidentally: The game would regard "null" as the name of a variable. But as that variable never was defined, it would actually have the value "nil".