Factorio Forums

Bilka wrote: ↑Fri Aug 14, 2020 1:48 pm During the cutscene the player does not have a character. You are trying to get a character inventory, so that does not work. I'd recommed to use the remote interface of the freeplay scenario to add extra starting item to players.

ptx0 wrote: ↑Fri Aug 14, 2020 3:43 pm

Bilka wrote: ↑Fri Aug 14, 2020 1:48 pm During the cutscene the player does not have a character. You are trying to get a character inventory, so that does not work. I'd recommed to use the remote interface of the freeplay scenario to add extra starting item to players.

LOL way to break a shitload of mods just as it's released, isn't that exactly what you didn't want?

trionicb wrote: ↑Fri Aug 14, 2020 3:20 pm Wouldn't that be a bug, calling the event when the character is not actually created?

GTX2GvO wrote: ↑Fri Aug 14, 2020 6:26 pm Seeing the "player created" event no longer gives access to the character inventory during freeplay, due to the cutscene.

What would allow access to the proper character inventory?

This little change basically broke just about every quick start mod out there relying on the character access during this event.

It's just to understand things myself, I don't make these mods. (I play with them )

local freeplay_interface =
{
  get_created_items = function()
    return global.created_items
  end,
  set_created_items = function(map)
    global.created_items = map or error("Remote call parameter to freeplay set created items can't be nil.")
  end,
  get_respawn_items = function()
    return global.respawn_items
  end,
  set_respawn_items = function(map)
    global.respawn_items = map or error("Remote call parameter to freeplay set respawn items can't be nil.")
  end,
  set_skip_intro = function(bool)
    global.skip_intro = bool
  end,
  set_chart_distance = function(value)
    global.chart_distance = tonumber(value) or error("Remote call parameter to freeplay set chart distance must be a number")
  end,
  set_disable_crashsite = function(bool)
    global.disable_crashsite = bool
  end,
  get_ship_items = function()
    return global.crashed_ship_items
  end,
  set_ship_items = function(map)
    global.crashed_ship_items = map or error("Remote call parameter to freeplay set created items can't be nil.")
  end,
  get_debris_items = function()
    return global.crashed_debris_items
  end,
  set_debris_items = function(map)
    global.crashed_debris_items = map or error("Remote call parameter to freeplay set respawn items can't be nil.")
  end
}

if not remote.interfaces["freeplay"] then
  remote.add_interface("freeplay", freeplay_interface)
end

script.on_init(function()
	
	remote.call("freeplay", "set_created_items", {coal=50})
	remote.call("freeplay", "set_ship_items", {coal=50})	
	remote.call("freeplay", "set_debris_items", {coal=50})
	
end)

script.on_init(function()
	
	-- removed crashsite and cutscene start, so on_player_created inventory safe
	remote.call("freeplay", "set_disable_crashsite", true)	
	
	-- Skips popup message to press tab to start playing
	remote.call("freeplay", "set_skip_intro", true)
end)

Rseding91 wrote: ↑Fri Aug 14, 2020 5:52 pm
The event is "player created"; not character created. In fact the character has been created just the player is in a cutscene. The player could also be in the god controller or the map editor or be a spectator; none of those have character entities. You can't assume the player controller is anything You need to check what it is before trying to use it: https://lua-api.factorio.com/latest/Lua ... oller_type

As for the freeplay scenario stuff; that also depends if the freeplay scenario is being used - which isn't guaranteed. It could be other scenarios which have no remote interface. I don't know if there's any documentation on what remote interfaces freeplay provides.

Schallfalke wrote: ↑Mon Aug 17, 2020 12:41 pm This leads me to a new question though:
How to make it work with both freeplay and sandbox (and other scenarios)?
Does it mean I need to duplicate my insertion code, so keeping using on_player_created event for sandbox, and using the dedicated remote interface of freeplay or on_cutscene_cancelled event for freeplay?

morsk wrote: ↑Mon Aug 17, 2020 8:18 pm

Schallfalke wrote: ↑Mon Aug 17, 2020 12:41 pm This leads me to a new question though:
How to make it work with both freeplay and sandbox (and other scenarios)?
Does it mean I need to duplicate my insertion code, so keeping using on_player_created event for sandbox, and using the dedicated remote interface of freeplay or on_cutscene_cancelled event for freeplay?

Duplicate it or put it in a function and call it from two places. But it only has to run once:

on_player_created:
- If player.controller_type isn't a cutscene, do the change immediately.
- If it's a cutscene, add the player's id to a table.

on_cutscene_cancelled:
- If the player's id is in the table, remove it, and do the change.

  if remote.interfaces["freeplay"] then   -- Added for 1.0 freeplay cutscene
    set_inventory(e)
  end

Peppe wrote: ↑Sat Aug 15, 2020 1:12 am defines.events.on_cutscene_cancelled can replace on_player_created.

Rseding91 wrote: ↑Fri Aug 14, 2020 5:52 pm As for the freeplay scenario stuff; that also depends if the freeplay scenario is being used - which isn't guaranteed. It could be other scenarios …