Page 1 of 1

[1.1.97] Pump connects misaligned to train

Posted: Sun Nov 19, 2023 10:29 pm
by studix2002
oil train outpost blueprint attached.
Graphical Glitch.png
Graphical Glitch.png (545.87 KiB) Viewed 908 times
the pumps don't align graphically but attached to the train ok

Re: [1.1.97] Pump connects misaligned to train

Posted: Sun Nov 19, 2023 11:32 pm
by disentius
Not a bug. your train (including locomotive) has to be on a straight section of track for pumps to align.

Re: [1.1.97] Pump connects misaligned to train

Posted: Sun Nov 19, 2023 11:46 pm
by studix2002
you are incorrect disentius

1. the lead locomotive only has to on straight rail.
2. the pumps are working but graphically are misaligned...so there is a bug there somewhere...either the pumps should'nt work in their current position or the graphics should align correctly

Re: [1.1.97] Pump connects misaligned to train

Posted: Mon Nov 20, 2023 12:07 pm
by boskid
Thanks for the report. I am going to move this to "wont fix".

Pump to fluid wagon sprites are prepared for a specific fluid wagon offsets under assumption that entire train is standing only on straight rails. In this specific scenario front rolling stock is standing partially on the curved rails which causes all fluid wagons sprites to be slightly shifted because of vertical selection shift logic. GFX team is not willing to rework pump sprites right now and is not willing to give up on the vertical selection logic, whenever any part of the train is on curved rails there may or may not be misalignment happening and it goes into undefined behavior because vertical selection shift is ugly hack which makes them apparently look better in some cases. If that train would not have locomotives facing the other way then it would work correctly because front rolling stock would be deduced to be on the bottom of this contraption and fluid wagons would have 0 vertical selection shift applied however directly after this blueprint is built, given there is equal amount of locomotives facing both train ends, selected front is not one next to the train stop in this specific case, vertical selection shift over fluid wagons is large and so the pumps misalignment.

Re: [1.1.97] Pump connects misaligned to train

Posted: Tue Nov 21, 2023 9:30 am
by disentius
I had not looked properly... excuse me.