Page 1 of 1

[0.15.32] Blueprint strings remove combinators with unknown signals

Posted: Fri Aug 04, 2017 5:23 am
by Optera
Problem:
When importing this blueprint string in a vanilla game it will not contain the bottom constant combinator.
Potentially as it holds an item (napalm) added by a 3rd mod.
viewtopic.php?f=193&t=50373&p=300895#p293003

Code: Select all

0eNrlmE1vmzAYx79K5TNUQBKSRtOOO1U77TZNyMCTxCrYyJh0WcV332PIe4A8dD1UWg+NCPbPz+vfdt5YnFVQaCENW74xkShZsuXPN1aKteSZ/c7sCmBLJgzkzGGS5/ZJq1gVShtWO0zIFH6zpV87d6dlai1KIxLXaC6kWxpVnBGC+pfDQBphBLRWNA+7SFZ5DBqXuF3fYYUqcYKSdlGEuIHDdvYDueiN0SqLYtjwrVDaDkmETipholylEKlVpArQvJ3vtVMkJPa5tKN9+09Dem6NSBtT69o6fGVhcLTQRtJwadxE5bGQ3ODyN8Z6j7PW2snjrMfelcgMaFJSYm5w6I41pMpm1PW99m9UlhKFL4cgUwJEaCXdIuMGBlEhyZ4Ck0SAzQmw0gBkBNaCwIIMSwX9xILel9Ug8omA5OmWywRSEtD3CMRCqwTKUsi1W8l7QJ8UQSXBjbVIXoZhE2wSckf5Z91knxfOsVXb190NNxnXcP6HNhxWUaNmMdfnkZiN7DfJC57lfYSAUoi/iwwd3aJs9lAmlMRW2arq9YTS9FhqL2DcVQUXAhLMTpgZaZt4dVOQmLkd7hG6SkyloQ8YUku2z7E5Vc2U7mUs6DI2QKEIRKW5FFU+hCHJwoETTBa9HNpmIRMNl2IaXMnAfcqG/+EaRe8ujFKFVYn6yYV221buh1Eyr/mr+6pU2k9ZjJG5GU3WpqcNQQuzycHKDOkkYc89qdCtKQ2oS+RO1Ahfp+Jo90ro0kQ3MdkKbSr85tRRzQgXeLJpI9OKry2+/S5wdrBiLk5UlSmq0ej6n0LrsKBn8JyWh9nRqhQSkWL7knYXWhL2yI/OgGcf8oLrxsgl+/Lu4FtQsYuaso9WWuWRkIhhS9RkGJGZ6XWwL7f6iT33rzWAvJ54dQgITintHD6/Hd6V1PDobQ6p1cD2HIcdVqgMOq4Uh+byDoeGG6dp5ly6jTLdbd98VNEdjftMNff1s9Vc8FE1Fl5lcUarucW7hMSr//Msjux4fzg5fSr/NPQDhdtGYEAWgkYWznov7FjD9wYXacPTv4bfe185OHishXeUApc7s8Eb4r1ywNd4uMKlMmVvSE0yRwhi2BN/3x/8hehW8tqwE4IenF0BELjeGBc/sj7k9BIZdCEnVGTQjUQdak6Yy7Of3hyW8RjvTEv2vPf/waiH5x/fH761R1iHbfFO2vo5nQah54fz8Kmu/wJy2JiL

Expected:
unknown items/signals are skipped individually as was the case with mods Foreman and blueprint String.

Re: [0.15.32] Blueprint strings remove combinators with unknown signals

Posted: Fri Aug 04, 2017 1:45 pm
by Rseding91
Thanks for the report. This is currently working correctly although it may not be the best way for it to work.

When importing a given entity if anything goes wrong with the import process the entity is discarded. In the case of constant combinators it tries to read the signals in the constant combinator construction, throws an error and the blueprint string import gives up on that constant combinator.

To change how that works would require re-writing every single entity-from-string constructor which isn't likely to happen soon.