Page 1 of 1

[kovarex] [15.33] Miner ghosts not on ore will still remove trees

Posted: Fri Aug 25, 2017 10:08 pm
by Seaish
This is pretty minor (ha) but worth documenting. If you shift-click a miner or a blueprint with a miner on some trees where there is no ore, it will still mark the trees for deconstruction even though it will never place the miner. I would expect the trees to be left alone, since there is no way to place the miner there. I'm not running any mods whatsoever. This is on multiplayer but probably can be reproduced on any configuration.

I also tried shift-clicking with landfill, but I imagine since trees can exist on land, behavior was as expected.

This probably happens because the order here is: User action -> if there are trees, remove them -> if miner entity, check for ore -> if no ore, break -> place ghost. It probably should be: User action -> if miner entity, check for ore -> if no ore, break -> if there are trees, remove them -> place ghost.

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Posted: Mon Aug 28, 2017 2:31 pm
by kovarex
You are right.
But changing the order isn't that easy, as the buildability check method is far from trivial and checks all the things together. I believe that splitting the code isn't worth the almost non-existent problems arising from this.

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Posted: Mon Aug 28, 2017 9:36 pm
by Jap2.0
That's interesting - this doesn't seem to happen in Grey goo mk. I. Perhaps that has to do with logic regarding the Recursive blueprints mod, or perhaps it had to do with an old version.

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Posted: Tue Aug 29, 2017 10:08 pm
by Seaish
That sounds valid. Thanks for checking.

Re: [kovarex] [15.33] Miner ghosts not on ore will still remove trees

Posted: Mon Jun 08, 2020 3:06 pm
by ickputzdirwech
This has been fixed. When you try this now just nothing happens.