[0.12.29][Steam][Twinsen]Changing from PM to AM crashes game

This subforum contains all the issues which we already resolved.
Post Reply
redredgreengreen
Manual Inserter
Manual Inserter
Posts: 4
Joined: Fri Mar 25, 2016 9:33 am
Contact:

[0.12.29][Steam][Twinsen]Changing from PM to AM crashes game

Post by redredgreengreen »

When changing system time from PM to AM, the game crashes. This was able to be replicated 6 out of 7 times (including the time it was discovered), and happened 3 times in game, and 4 times on the main menu(The only time it failed to occur was in the main menu). It is important to note that switching the system time from AM to PM dose nothing, and that only the game crashes, not the system.

All tests occurred between 2:30 AM and 3:15 AM (PST)

(Example) Time 2:45 PM, changed to 2:45 AM. Game Crashes.
Time 3:00 AM, changed to 3:00 PM. Game does not crash.


Game Specs

Version 0.12.29, played on steam.

System Specs

Windows 7 Home Premium Service Pack 1, 64 bit OS

8GB Ram

2048 MB VRam

AMD FX(tm)- 8120 Eight Core Processor, 3.10 GHz

Logs

Edit notes: I moved the files in drop box, so this post needed new links. All the links are updated now, and are confirmed to work.

In menu test: https://www.dropbox.com/s/63mubdrjykp1e ... 1.log?dl=0
In game test: https://www.dropbox.com/s/drps1g42zwt4z ... 2.log?dl=0
Only Failed Attempt: https://www.dropbox.com/s/nl2k3gwlw1oja ... 9.log?dl=0


Saves

https://www.dropbox.com/s/b8hz1irl5rz2m ... 1.zip?dl=0
https://www.dropbox.com/s/52plf10mdlu3a ... 2.zip?dl=0
https://www.dropbox.com/s/6q34dizyqa8kl ... 3.zip?dl=0
Last edited by redredgreengreen on Mon Mar 28, 2016 2:09 am, edited 2 times in total.

Twinsen
Factorio Staff
Factorio Staff
Posts: 1330
Joined: Tue Sep 23, 2014 7:10 am
Contact:

Re: [0.12.29][Steam]Changing from PM to AM crashes game

Post by Twinsen »

Does your game crash, or does it freeze? I can't reproduce the crash, but it does freeze for me.

All your links give 404.

redredgreengreen
Manual Inserter
Manual Inserter
Posts: 4
Joined: Fri Mar 25, 2016 9:33 am
Contact:

Re: [0.12.29][Steam][Twinsen]Changing from PM to AM crashes game

Post by redredgreengreen »

It freezes. I had not actually thought of the difference when I posted this, so if you are getting it to freeze, you are getting exactly what I got.
Also, let me see if I can fix the links.

Edit: Links Fixed now!

Twinsen
Factorio Staff
Factorio Staff
Posts: 1330
Joined: Tue Sep 23, 2014 7:10 am
Contact:

Re: [0.12.29][Steam][Twinsen]Changing from PM to AM crashes game

Post by Twinsen »

I found the issue but there is not easy fix and it's not such a major problem as far as I can see.

For reference, this is caused by std::this_thread::sleep_for
http://stackoverflow.com/questions/1972 ... adjustment
According to a comment "VC++ 2012's implementation of sleep_for does not conform to the standard."

Using a different sleep function might not be a good idea since it can cause a hundred other unforeseen problems on our unreliable main loop.

User avatar
Jon8RFC
Filter Inserter
Filter Inserter
Posts: 553
Joined: Tue May 10, 2016 3:39 pm
Contact:

Re: [0.12.29][Steam][Twinsen]Changing from PM to AM crashes game

Post by Jon8RFC »

This one was fixed when y'all went to VC++ 2017, I think. Confirmed broken on 0.12.35 and working on 0.16.22.
Image

redredgreengreen
Manual Inserter
Manual Inserter
Posts: 4
Joined: Fri Mar 25, 2016 9:33 am
Contact:

Re: [0.12.29][Steam][Twinsen]Changing from PM to AM crashes game

Post by redredgreengreen »

Oh man, I completely forgot I found this. Nice to know it actually got solved.

Post Reply

Return to “Resolved Problems and Bugs”