[0.15.33, minor] changelog after changing mods

[gheift]

Hi,

the changelog, which shows up after the updater is also displayed, if the mod configuration is changed in game. I do expect the changelog not to show up after I change my mod configuration.

How to reproduce:

• use an old version of factorio
• let the game update itself (either via auto update or About → Check update)
• factorio restarts itself after the update
• the changelog is chown
• modify mod configuration (enable/disable/install/deinstall a mod)
• factorio restarts itself after the config change
• the changelog is shown again, but I do not expect it here

Kind regards,
Gerhard

[kovarex]

I tried to reproduce it (on windows), and it didn't do that.
It is controlled by command line parameter (whether the log should be shown or not), and I checked that there is code that explicitelly removes this parameter when restarting, so I don't know how could it happen.

What is the system you tried it on, Could you provide the log after it happens? (Both factorio-current and previous).

[Rseding91]

I tried to reproduce it (on windows), and it didn't do that.
It is controlled by command line parameter (whether the log should be shown or not), and I checked that there is code that explicitelly removes this parameter when restarting, so I don't know how could it happen.

What is the system you tried it on, Could you provide the log after it happens? (Both factorio-current and previous).

I think that code is new to 0.16 as a fix for something else. So, it's probably fixed for 0.16.

[kovarex]

I tested it in 0.15 and couldn't reproduce it as well, but whatever.

[gheift]

Sorry for the late replay, I am running on Debian. Here are the requested logs:

Initial start

Code: Select all

   0.000 2017-09-02 01:42:43; Factorio 0.15.32 (build 30820, linux64, alpha)
   0.253 Operating system: Linux (Debian unstable)
   0.253 Not rotating logs.
   0.253 Program arguments: "bin/x64/factorio" 
   0.253 Read data path: /home/gheift/.local/opt/factorio/test-update/data
   0.253 Write data path: /home/gheift/.local/opt/factorio/test-update
   0.253 Binaries path: /home/gheift/.local/opt/factorio/test-update/bin
   0.261 System info: [CPU:         Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, 8 cores, RAM: 16012MB]
   0.262 Display options: [FullScreen: 0] [VSync: 0] [UIScale: 130.328%] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.296 Available display adapters: 1
   0.296  [0]: resolution 3840x2160px at [0,0]
   0.296 Create display on adapter 0. Size 1280x720 at position [1270, 702].
   0.352 Initialised OpenGL:[0] Gallium 0.4 on AMD POLARIS11 (DRM 3.15.0 / 4.12.0-1-amd64, LLVM 4.0.1); driver: 3.0 Mesa 17.1.5
   0.352     Video memory size (dedicated/total available/current available): 4020/8115/4016 MB
   0.383 Graphics settings preset: very-high
   0.383 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 29.918%] [DXT: false]
   0.493 Loading mod core 0.0.0 (data.lua)
   0.497 Loading mod base 0.15.32 (data.lua)
   0.565 Loading mod base 0.15.32 (data-updates.lua)
   0.587 Checksum for core: 2408012280
   0.587 Checksum of base: 3610659478
   0.763 Info PlayerData.cpp:58: Local player-data.json available, timestamp 1504309247
   0.763 Info PlayerData.cpp:65: Cloud player-data.json unavailable
   0.844 Loaded shader file /home/gheift/.local/opt/factorio/test-update/data/core/graphics/shaders/game.glsl
   0.844 Loaded shader file /home/gheift/.local/opt/factorio/test-update/data/core/graphics/shaders/zoom-to-world.glsl
   0.845 Crop bitmaps.
   0.845 Atlases were not loaded from disk cache.
libpng warning: iCCP: known incorrect sRGB profile
  21.528 Initial atlas bitmap size is 16384
  21.693 Created atlas bitmap 16384x16380
  21.702 Created atlas bitmap 16384x1289
  21.721 Created atlas bitmap 16384x3181
  21.749 Created atlas bitmap 16384x4755
  21.749 Created atlas bitmap 8192x1920
  21.754 Created atlas bitmap 8192x804
  21.754 Created atlas bitmap 8192x2028
  21.755 Info AtlasCache.cpp:124: Exception while loading atlas cache: Error when opening /home/gheift/.local/opt/factorio/test-update/atlas-cache.dat for reading: No such file or directory. This can be probably ignored
  21.755 Atlases were not loaded from disk cache.
libpng warning: iCCP: known incorrect sRGB profile
  34.377 Sprites loaded
  37.874 Sprite atlas cached.
  37.874 Convert atlas 8192x1920 to: mipmap 
  37.965 Convert atlas 8192x804 to: mipmap 
  38.022 Convert atlas 8192x2028 to: trilinear-filtering 
  38.138 Loading sounds...
  60.327 Custom inputs active: 0
  60.361 Factorio initialised
 129.314 Info Updater.cpp:751: Downloading https://updater.factorio.com/get-available-versions?username=gheift&token=<private>&apiVersion=2
 129.965 1 packages available to download (experimental updates disabled).
 135.834 Info Updater.cpp:751: Downloading https://updater.factorio.com/get-download-link?username=gheift&token=<private>&package=core-linux64&from=0.15.32&to=0.15.33&isTarget=true&apiVersion=2
 140.526 Info Updater.cpp:230: Downloading http://eu3.factorio.com/updates/core-linux64-0.15.32-0.15.33-update.zip?key=RvQi98HYnVKm2jhKmyUS1Q&expires=1504309534 to /home/gheift/.local/opt/factorio/test-update/temp/core-linux64-0.15.32-0.15.33-update.zip
 147.499 Info Updater.cpp:241:  => 200
 147.646 Info Updater.cpp:382: Applying update /home/gheift/.local/opt/factorio/test-update/temp/core-linux64-0.15.32-0.15.33-update.zip
 148.189 Info AppManager.cpp:763: Restarting Factorio
 148.307 Goodbye

After the update

Code: Select all

   0.000 2017-09-02 01:45:12; Factorio 0.15.33 (build 30852, linux64, alpha)
   0.246 Operating system: Linux (Debian unstable)
   0.246 Not rotating logs.
   0.246 Program arguments: "bin/x64/factorio" "--autoupdate-finished" 
   0.246 Read data path: /home/gheift/.local/opt/factorio/test-update/data
   0.246 Write data path: /home/gheift/.local/opt/factorio/test-update
   0.246 Binaries path: /home/gheift/.local/opt/factorio/test-update/bin
   0.256 System info: [CPU:         Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, 8 cores, RAM: 16012MB]
   0.256 Display options: [FullScreen: 0] [VSync: 0] [UIScale: 130.328%] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.292 Available display adapters: 1
   0.292  [0]: resolution 3840x2160px at [0,0]
   0.292 Create display on adapter 0. Size 1280x720 at position [1270, 702].
   0.350 Initialised OpenGL:[0] Gallium 0.4 on AMD POLARIS11 (DRM 3.15.0 / 4.12.0-1-amd64, LLVM 4.0.1); driver: 3.0 Mesa 17.1.5
   0.350     Video memory size (dedicated/total available/current available): 4020/8115/4016 MB
   0.398 Graphics settings preset: very-high
   0.398 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 29.918%] [DXT: false]
   0.504 Loading mod core 0.0.0 (data.lua)
   0.511 Loading mod base 0.15.33 (data.lua)
   0.576 Loading mod base 0.15.33 (data-updates.lua)
   0.603 Checksum for core: 1161214653
   0.603 Checksum of base: 1503927233
   0.783 Info PlayerData.cpp:58: Local player-data.json available, timestamp 1504309512
   0.784 Info PlayerData.cpp:65: Cloud player-data.json unavailable
   0.886 Loaded shader file /home/gheift/.local/opt/factorio/test-update/data/core/graphics/shaders/game.glsl
   0.887 Loaded shader file /home/gheift/.local/opt/factorio/test-update/data/core/graphics/shaders/zoom-to-world.glsl
   0.887 Crop bitmaps.
   0.887 Atlases were not loaded from disk cache.
libpng warning: iCCP: known incorrect sRGB profile
  12.273 Initial atlas bitmap size is 16384
  12.436 Created atlas bitmap 16384x16379
  12.446 Created atlas bitmap 16384x1289
  12.466 Created atlas bitmap 16384x3181
  12.493 Created atlas bitmap 16384x4761
  12.494 Created atlas bitmap 8192x1912
  12.499 Created atlas bitmap 8192x800
  12.499 Created atlas bitmap 8192x2028
  12.499 Atlases were not loaded from disk cache.
libpng warning: iCCP: known incorrect sRGB profile
  25.258 Sprites loaded
  38.281 Sprite atlas cached.
  38.281 Convert atlas 8192x1912 to: mipmap 
  38.396 Convert atlas 8192x800 to: mipmap 
  38.448 Convert atlas 8192x2028 to: trilinear-filtering 
  38.561 Loading sounds...
  40.371 Custom inputs active: 0
  40.398 Factorio initialised
 137.615 Info HttpSharedState.cpp:44: Downloading https://mods.factorio.com/api/mods?page_size=max
 158.323 Info HttpSharedState.cpp:111: Status code: 200
 170.005 Info HttpSharedState.cpp:44: Downloading https://mods.factorio.com/api/mods/ght-bluebuild
 171.178 Info HttpSharedState.cpp:111: Status code: 200
 172.172 Info ModPortal.cpp:194: Downloading /api/downloads/data/mods/1527/ght-bluebuild_0.1.10.zip?username=gheift&token=<private> to /home/gheift/.local/opt/factorio/test-update/temp/ght-bluebuild_0.1.10.zip
 172.172 Info HttpSharedState.cpp:44: Downloading https://mods.factorio.com/api/downloads/data/mods/1527/ght-bluebuild_0.1.10.zip?username=gheift&token=<private>
 173.018 Info HttpSharedState.cpp:111: Status code: 200
 176.955 Info AppManager.cpp:763: Restarting Factorio
 176.955 Restarting for reason other than update. Setting execute permission skipped.
 177.054 Goodbye

After installing the mod

Code: Select all

0.000 2017-09-02 01:48:09; Factorio 0.15.33 (build 30852, linux64, alpha)
   0.246 Operating system: Linux (Debian unstable)
   0.247 Not rotating logs.
   0.247 Program arguments: "bin/x64/factorio" "--autoupdate-finished" 
   0.247 Read data path: /home/gheift/.local/opt/factorio/test-update/data
   0.247 Write data path: /home/gheift/.local/opt/factorio/test-update
   0.247 Binaries path: /home/gheift/.local/opt/factorio/test-update/bin
   0.252 System info: [CPU:         Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz, 8 cores, RAM: 16012MB]
   0.253 Display options: [FullScreen: 0] [VSync: 0] [UIScale: 130.328%] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.288 Available display adapters: 1
   0.288  [0]: resolution 3840x2160px at [0,0]
   0.288 Create display on adapter 0. Size 1280x720 at position [1270, 702].
   0.343 Initialised OpenGL:[0] Gallium 0.4 on AMD POLARIS11 (DRM 3.15.0 / 4.12.0-1-amd64, LLVM 4.0.1); driver: 3.0 Mesa 17.1.5
   0.344     Video memory size (dedicated/total available/current available): 4020/8115/4016 MB
   0.381 Graphics settings preset: very-high
   0.382 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 29.918%] [DXT: false]
   0.481 Loading mod settings ght-bluebuild 0.1.10 (settings.lua)
   0.482 Loading mod core 0.0.0 (data.lua)
   0.487 Loading mod base 0.15.33 (data.lua)
   0.552 Loading mod ght-bluebuild 0.1.10 (data.lua)
   0.572 Loading mod base 0.15.33 (data-updates.lua)
   0.597 Checksum for core: 1161214653
   0.597 Checksum of base: 1503927233
   0.597 Checksum of ght-bluebuild: 2896187370
   0.777 Info PlayerData.cpp:58: Local player-data.json available, timestamp 1504309689
   0.777 Info PlayerData.cpp:65: Cloud player-data.json unavailable
   0.877 Loaded shader file /home/gheift/.local/opt/factorio/test-update/data/core/graphics/shaders/game.glsl
   0.877 Loaded shader file /home/gheift/.local/opt/factorio/test-update/data/core/graphics/shaders/zoom-to-world.glsl
   0.887 Initial atlas bitmap size is 16384
   1.048 Created atlas bitmap 16384x16379
   1.057 Created atlas bitmap 16384x1289
   1.078 Created atlas bitmap 16384x3181
   1.108 Created atlas bitmap 16384x4761
   1.108 Created atlas bitmap 8192x1912
   1.110 Created atlas bitmap 8192x800
   1.110 Created atlas bitmap 8192x2028
   3.903 Atlases loaded from disk cache.
   4.680 Sprites loaded
   4.680 Convert atlas 8192x1912 to: mipmap 
   4.810 Convert atlas 8192x800 to: mipmap 
   4.871 Convert atlas 8192x2028 to: trilinear-filtering 
   4.986 Loading sounds...
   6.815 Custom inputs active: 2
   6.842 Factorio initialised

So basically the --autoupdate-finished argument is not removed for the restart caused by installing a mod. Maybe its already fixed due to this bug report: viewtopic.php?f=213&t=52217

Kind regards,
Gerhard

[posila]

So basically the --autoupdate-finished argument is not removed for the restart caused by installing a mod. Maybe its already fixed due to this bug report: viewtopic.php?f=213&t=52217

Yes, fix for 52217 also fixes this one. The bug is isolated to Linux and macOS versions; it is at least worth mentioning your OS, but it is always best to include the log when reporting a bug

Thanks for the report.