[0.17.54] FPS now going >60 at game.speed>1 ?

Bugs that are actually features.
Post Reply
User avatar
TheBloke
Fast Inserter
Fast Inserter
Posts: 123
Joined: Mon Dec 03, 2018 2:48 am
Contact:

[0.17.54] FPS now going >60 at game.speed>1 ?

Post by TheBloke »

Platform tested on: macOS 10.14.5
Version tested: 0.17.54 standalone

This screenshot pretty much says it all..
Image

Having seen nothing in the changelog that suggests FPS should be unlocked from 60, I thought I should report this as a bug until informed otherwise.

I am running some bot layout/throughput tests. I set /c game.speed = 25 before starting. In version 0.17.53 (and all before), this would result in me getting 850-1000 UPS, with FPS of course locked at 60.

I just upgraded to 0.17.54, started another of my tests, and was amazed to see:
  • That UPS was now locking to 120 when game.speed was >=2
  • That my overall UPS is way down. Instead of 850-1000, I am maxing out at 350-400. I assume this is from the extra work of drawing twice as many frames.
Log file attached.
Attachments
TheBloke.04072019.FPS120.factorio-current.log
(18.09 KiB) Downloaded 35 times

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5152
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [0.17.54] FPS now going >60 at game.speed>1 ?

Post by Klonan »

Is v-sync turned on or off?

User avatar
TheBloke
Fast Inserter
Fast Inserter
Posts: 123
Joined: Mon Dec 03, 2018 2:48 am
Contact:

Re: [0.17.54] FPS now going >60 at game.speed>1 ?

Post by TheBloke »

Klonan wrote:
Thu Jul 04, 2019 1:15 pm
Is v-sync turned on or off?
It was off and ah yes, turning it on has restored me to 60 FPS and expected levels of UPS (~1000 at the moment).

However before 0.54, it was 60 with it both on and off. Expected change?

posila
Factorio Staff
Factorio Staff
Posts: 5202
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.17.54] FPS now going >60 at game.speed>1 ?

Post by posila »

That's how it is expected to work. I was not aware it didn't work that way on macOS.

The change was - I reverted workaround SDL had for broken v-sync in macOS 10.14.3, because it's fixed on macOS 10.14.4 and therefore the workaround was present only in developer versions of SDL anyway. I didn't know it limited framerate even with vsync turned off.

User avatar
TheBloke
Fast Inserter
Fast Inserter
Posts: 123
Joined: Mon Dec 03, 2018 2:48 am
Contact:

Re: [0.17.54] FPS now going >60 at game.speed>1 ?

Post by TheBloke »

posila wrote:
Thu Jul 04, 2019 1:24 pm
That's how it is expected to work. I was not aware it didn't work that way on macOS.

The change was - I reverted workaround SDL had for broken v-sync in macOS 10.14.3, because it's fixed on macOS 10.14.4 and therefore the workaround was present only in developer versions of SDL anyway. I didn't know it limited framerate even with vsync turned off.
Ahh, thanks for the explanation. Glad all is working as intended now.

Post Reply

Return to “Not a bug”