[1.1.53] LuaPermissionGroup has different behaviour with players in some cases

[ZwerOxotnik]

Expected:

• Players without admin permissions can be moved to a different permission group by a mod/command/script

Steps to reproduce:

• Create new permission groups with names like: "1", "2", "3" etc via a mod or manually
• Demote an admin using /demote nickname
• Change its permission group via command/script

Actual Results:

• 1st case: using LuaPermissionGroup.add_player in a command, it didn't change permission group for player and returned false as result in LuaPermissionGroup.add_player.
• 2nd case: in on_player_demoted event in a mod, it changed permission group for player successfully and returned true as result in LuaPermissionGroup.add_player.

Notes:

• I checked it in single-player only
• I didn't check it with all events and defines.input_action
• I set defines.input_action.edit_permission_group as true for all groups, otherwise it won't allow me to move admins etc between groups via command/script
• I noticed it in my mod

[boskid]

Thanks for the report, however this is literally how it was implemented: LuaPermissionGroup does an extra permission check when used as part of console command: in that case it checks if player is an admin and has the EditPermissionGroup permission. There are various checks like that in code, like LuaPlayer::admin (write) will fail when used as part of console command by a player which is not an admin.

[ZwerOxotnik]

If I understand correctly, I just should use such actions in different events instead. (though, it seems strange)