Achievement rounding issue

Things that we don't consider worth fixing at this moment.
Post Reply
PiggyWhiskey
Filter Inserter
Filter Inserter
Posts: 252
Joined: Wed May 13, 2015 5:28 am
Contact:

Achievement rounding issue

Post by PiggyWhiskey »

I recently hit 10k Circuits for the achievement, and noticed the rounding issue.

It should round down to give a more accurate impression of progress.

Image

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5151
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: Achievement rounding issue

Post by Klonan »

PiggyWhiskey wrote:I recently hit 10k Circuits for the achievement, and noticed the rounding issue.

It should round down to give a more accurate impression of progress.

Image
hmm, seems fine to me

PiggyWhiskey
Filter Inserter
Filter Inserter
Posts: 252
Joined: Wed May 13, 2015 5:28 am
Contact:

Re: Achievement rounding issue

Post by PiggyWhiskey »

That was about 30-60 seconds before the achievement triggered. No green background.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5151
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: Achievement rounding issue

Post by Klonan »

PiggyWhiskey wrote:That was about 30-60 seconds before the achievement triggered. No green background.
Hmm okay :D

Thanks for the report

kovarex
Factorio Staff
Factorio Staff
Posts: 8078
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: Achievement rounding issue

Post by kovarex »

I don't see anything in the image, and I don't know what is the issue.

Zeblote
Filter Inserter
Filter Inserter
Posts: 973
Joined: Fri Oct 31, 2014 11:55 am
Contact:

Re: Achievement rounding issue

Post by Zeblote »

kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
It's saying 10k/10k but the achievement didn't trigger yet. You're probably rounding these numbers up instead of down?

hoho
Filter Inserter
Filter Inserter
Posts: 677
Joined: Sat Jan 18, 2014 11:23 am
Contact:

Re: Achievement rounding issue

Post by hoho »

kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
The problem is that goal is to reach 10k and the display shows there to be 10.0k while in reality it's probably around 9.99k rounded up.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5151
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: Achievement rounding issue

Post by Klonan »

kovarex wrote:I don't see anything in the image, and I don't know what is the issue.
Mirror:
Image

kovarex
Factorio Staff
Factorio Staff
Posts: 8078
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: Achievement rounding issue

Post by kovarex »

I don't consider it a bug, it is a way rounding works.

User avatar
HanziQ
Former Staff
Former Staff
Posts: 630
Joined: Fri Mar 27, 2015 7:07 am
Contact:

Re: Achievement rounding issue

Post by HanziQ »

How is this not a bug? If the value is 9999 for example, it should be displayed as 9.9k, not 10.0k. It maybe is the way rounding works, but it's the wrong rounding.

solntcev
Long Handed Inserter
Long Handed Inserter
Posts: 81
Joined: Tue Jun 21, 2016 8:37 am
Contact:

Re: Achievement rounding issue

Post by solntcev »

Same issue with fluids display: often you can see (2.0 of 2) or (3.0 of 3) resources highlighted as red.
Maybe you need to make custom rounding function for displayed values? because rounding up make no sense in context of available resources.

hoho
Filter Inserter
Filter Inserter
Posts: 677
Joined: Sat Jan 18, 2014 11:23 am
Contact:

Re: Achievement rounding issue

Post by hoho »

kovarex wrote:I don't consider it a bug, it is a way rounding works.
That's the thing - rounding doesn't give the result a non-programmer would expect. It should be rounded *down*, not to closest full number.

Alternatively, why not just have higher precision numbers there? Just 3 significant positions doesn't make that much sense when you could fit pretty much anything there without too much trouble.

Post Reply

Return to “Won't fix.”