[0.13] [Pending] Ingame Mod updates failing

[Kamel]

Tried using the ingame mod-update function but it fails

Bug a) If you never authorized the game will download empty files and crash on restart
Forgot to save the log but it's basically the download call without username e.g. but status 200

Code: Select all

85.848 Info HttpSharedState.cpp:42: Downloading https://mods.factorio.com/api/downloads/data/mods/23/Landfill_2.1.8.zip?username=&token=<private>
 106.301 Info HttpSharedState.cpp:XX: Status code: 200

[HanziQ]

How did you manage to get the game to download a mod without logging in?

[Talguy]

Technically the rest API is at fault, since a 403 error would be expected 401 is possible too but I'm not sure if digest or basic auth is used by factorio.

[HanziQ]

Of course it is at fault, but I can't fix it if I can't reproduce it, I made some attempts though.

[brunzenstein]

Of course it is at fault, but I can't fix it if I can't reproduce it, I made some attempts though.

here you are:

Code: Select all

   0.000 2016-06-28 11:32:17; Factorio 0.13.0 (Build 22782, mac, alpha)
   0.000 Operating system: Mac OS X 10.11.5
   0.000 Program arguments: "/Applications/factorio.app" 
   0.000 Read data path: /Applications/factorio.app/Contents/data
   0.000 Write data path: /Users/borisvonluhovoy/Library/Application Support/factorio
   0.000 Binaries path: /
   0.028 Graphics options: [FullScreen: false] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: low] [Video memory usage: all] [Light scale: 20%] [Screen: 255] [DXT: auto]
   0.034 Available display adapters: 1
   0.034  [0]: resolution 1280x800px at [0,0]
   0.034 Create display on adapter 0. Size 1280x720 at position [0, 22].
   0.229 Initialised OpenGL:[0] NVIDIA GeForce 9400M OpenGL Engine; driver: 2.1 NVIDIA-10.0.48 310.90.10.05b12
   0.491 Loading mod core 0.0.0 (data.lua)
   0.498 Loading mod base 0.13.0 (data.lua)
   0.675 Checksum for core: 1399339455
   0.675 Checksum for mod base: 2039900801
   1.460 Initial atlas bitmap size is 8192
   1.465 Created atlas bitmap 8192x6038
   1.470 Created atlas bitmap 4096x4096
   1.470 Created atlas bitmap 4096x692
  19.277 Sprites loaded
  19.277 Convert atlas 4096x4096 to: compressed 
  20.082 Convert atlas 4096x692 to: compressed 
  20.182 Loading sounds...
  23.012 Custom inputs active: 0
  23.012 Info Updater.cpp:751: Downloading https://www.factorio.com/updater/get-available-versions?username=brunzenstein&token=<private>&apiVersion=2
  24.269 0 packages available to download (experimental updates enabled).
  24.358 Factorio initialised
  35.856 Info HttpSharedState.cpp:42: Downloading https://mods.factorio.com/api/mods?page_size=max&order=alpha
  36.988 Info HttpSharedState.cpp:90: Status code: 200
  40.366 Info HttpSharedState.cpp:42: Downloading https://mods.factorio.com/api/mods?page_size=max&order=alpha
  40.877 Info HttpSharedState.cpp:90: Status code: 200
  53.344 Info HttpSharedState.cpp:42: Downloading https://mods.factorio.com/api/mods/Potato
  53.492 Info HttpSharedState.cpp:90: Status code: 200
  57.085 Info ModPortal.cpp:159: Downloading /api/downloads/data/mods/17/Potato_1.0.0.zip?username=brunzenstein&token=<private> to /Users/borisvonluhovoy/Library/Application Support/factorio/temp/Potato_1.0.0.zip
  57.085 Info HttpSharedState.cpp:42: Downloading https://mods.factorio.com/api/downloads/data/mods/17/Potato_1.0.0.zip?username=brunzenstein&token=<private>
  57.673 Info HttpSharedState.cpp:90: Status code: 200
  57.689 Error Util.cpp:57: Updated version has same file name.
  70.025 Goodbye

[Ubertwink]

I get a "Updated version has same file name." crash on attempting to download a mod from mod portal. I can provide logs if someone tells me where they are.

[Loewchen]

I get a "Updated version has same file name." crash on attempting to download a mod from mod portal. I can provide logs if someone tells me where they are.

That is a different issue and already fixed: viewtopic.php?f=30&t=27109

[Kamel]

Well, it was the first launch after installing 0.13 and I immediately went to mods and checked for updates and subsequently on update.
It probably was a side effect of the mod portal not beeing fully accessible at the time.

I had a second issue where the game would download 1KB zip files and crash on restart but figured out it was due to the mod portal acting up - so it was probably something similiar.
I just tried to repro it but it would ask me for login everytime, so ... file under "hard to reproduce but may occure on full moon"