[2.0.10] Pausing while a GUI is open and then resuming cause the same GUI to be unopenable

[PoulpoGaz]

Steps to reproduce, with more details at step 4:

1. Open any GUI or panel except: Factoriopedia (can be used while paused), tips (can be used while paused) and tech tree (game already paused).
2. Pause the game with the pause key (not escape!)
3. Resume the game
4. Try to open the GUI you just opened. If you choose to click on an entity, you should click on the same entity. Depending which GUI you opened at step 1, behavior is different:
   • Entity based GUI: it is impossible to reopen the GUI even after clicking more than once. All other reachable entity GUI can be open. Expected behavior: clicking on the entity should open the GUI.
   • Panel: clicking twice, or using the associated shortcut twice, is required to open the same panel. Opening any other panel works with one click. Expected behavior: clicking once should open the panel.
   In both case, just after resuming the game, pushing ESC twice is needed to open game menu while no GUI seems open. Expected behavior: pushing ESC once should open game menu while no GUI are open.

Conclusion:
An open GUI isn't properly closed when the game is paused with PAUSE button, except for Factoriopedia, Tips and Tech tree.

[fluke]

This looks like a dupe of 116851 still present in 2.0.11

Also back in 1.1 pausing didn't close the inventory at all, and it was nice to be able to browse this menu while paused.

As a workaround I added a keybind to toggle game.tick_paused based on https://mods.factorio.com/mod/pause-commands to restore this behavior, since this leaves inventory visible:

Code: Select all

-- control.lua
script.on_event("pause-toggle", function(event)
    game.tick_paused = not game.tick_paused
end)

Code: Select all

-- data.lua
local button={
    type = "custom-input",
    name = "pause-toggle",
    key_sequence = "SHIFT + SPACE",
    consuming = "none"
}
data:extend{button}