[2.0.15] Can't pan diagonally in editor

[spacedog]

Steps to reproduce:

1. Switch to /editor mode
2. Set the game speed to 64x
3. Zoom all the way in
4. Attempt to pan diagonally (e.g. up and left at the same time)

No panning occurs. It will only work if you release one of the keys and pan in a single direction.

Panning has always been a little goofy in the editor at high game speeds, but I don't recall it being completely broken like this prior to 2.0. More importantly, I've hit similar issues in normal gameplay -- sometimes to the point where I have to quit/restart the game to fix it -- which is also new for 2.0. (And there have been a few threads on the steam forums about the same issue.)

I fully expect this to get thrown in the "don't care" dumpster for the /editor use case, but I'm reporting it anyway in case this simple repro ends up being the same issue that's intermittently hitting people in normal gameplay.

[BraveCaperCat]

If you use mods to allow for up to 128 times faster game speed, then you cannot move horizontally or vertically while zoomed fully in. This and the original statement also apply to remote view. Note that speeds slower than 64 or 128 have a reduced impact on movement speed in the editor and remote view.

[spacedog]

Just for clarity this repro is for the base game, with no mods at all (including any space age mods).

I have heard reports of this in the past at game speeds greater than 64x. But I've never seen this without mods until 2.0.

The bigger issue is that whatever problem in the code is getting in the way of correctly processing input at high game speeds, now seems to be happening occasionally during normal 1x speed gameplay as well. And rarely it will get stuck like that and you have to restart the game.

[Edit: It's also super weird to me that this would have anything to do with the zoom level... although I've noticed this in the past. For example you can get completely different UPS numbers based on the zoom level, even with just a couple chunks worth of factory and a beast of a PC.]

[Rseding91]

Thanks for the report. The editor attempts to move at a constant speed regardless of game-speed setting but when the speed is set this high the movement becomes so slow that it doesn't actually move. Since it's not realistic to ever play a map at 64x speed (virtually nothing can exist in order to maintain that simulation speed) I don't consider this worth poking at. If anything, I would remove the 64x speed option if enough people complain about it.

[spacedog]

Yes it moves slower, but that's not the problem.

It just completely stops moving if you try panning diagonally. Panning on a single axis works (although at the expected slower speed). You can have it go between moving and not moving by pressing/releasing the second movement key.

There's clearly a bug of some sort here. I agree it's not an interesting bug for the /editor case. But I'm occasionally seeing the same thing in normal 1x gameplay that forces me to quit/restart.

Also, FWIW, my PC handles up to around a 500 SPM factory just fine at 64x speed... Congrats on all that optimization work I guess.

[posila]

Yes, Rseding acknowledged the bug (said "so slow that it doesn't actually move") and assessed it as not worth fixing ("don't consider this worth poking at")

It stops because positions are using fixed point numbers with 8 bits for fractional part. So if anything tries to move by less than 1/256th of a tile, the movement gets truncated to zero. It works in axis aligned movement, because it works out to be larger than 1/256th of a tile, but in diagonal the speed in each axis works out to be less than 1/256th of a tile.

If something like that happens to you with game speed 1, then I report that bug instead.

[BraveCaperCat]

It might be possible to fix it you simply switched the expected game speed (The value you can change in mods and the /c command) with the actual game speed (The current ups divided by the maximum ups at game speed 1, usually 60). I had a similar issue in one of my own projects where the text and buttons for a menu were off screen because I expected the screen to be exactly 1920 by 1080 pixels, when Windows actually had the scaling setting set to 125% instead of 100% like the application-in-progress expected. Changing that fixed the issue, and changing expected screen size to actual/current screen size fixed the issue with scaling set to 125%. Interesting side-story (I hope) but (almost) completely unrelated.

[spacedog]

...but in diagonal the speed in each axis works out to be less than 1/256th of a tile.

Okay, thank you. This was the missing piece of information. It makes sense that player movement would work this way, to keep diagonal movement from being faster than on-axis movement. I didn't realize the camera panning was doing the same thing.

I've definitely had the same thing happen in normal 1x gameplay a few times since 2.0, and it gets stuck that way until the game is restarted. But it sounds like it's probably a different root cause for that issue. Oh well.

Thanks, and sorry for the noise.