[Genhis][2.0.15] Cancelling partially-fulfilled inventory request leaves the icon in place

[Sachertorte]

Given the following rocket inventory requests, made using the ghost cursor in remote view:

11-16-2024, 16-42-13.png (8.51 KiB) Viewed 289 times

A rocket can only contain 5 EM plants, so I want to cancel the unfulfilled request for 17 EM plants, which I would normally do by right-clicking. However, that actually instructs the bots to remove the 3 items in that slot (which AFAIK is what I would expect from left-clicking). I don't know if this is a bug.

11-16-2024, 16-43-53.png (15.68 KiB) Viewed 289 times

11-16-2024, 16-44-00.png (10.17 KiB) Viewed 289 times

This visually leaves a request for 17 EM plants in place. There is not actually a request for 17 EM plants, as far as I can tell, because bots do not deliver anything to fill that slot. I feel certain this is a bug.

The slot cannot be cleared by left- or right-clicking, but it can it can be cleared by overwriting the slot with another request and then cancelling it before it is fulfilled.

The issue may be related to quality because if I get the bots to remove the 2 uncommon EM plants from the rocket, then issue a request for 20 uncommon EM plants, 2 of which are fulfilled, and then right click that inventory slot, the remaining request is cancelled but the uncommon EM plants stay in the inventory. (This could also be unrelated to quality, and just depends on whether the rocket inventory is full?)

Whatever the cause, it can be resolved on the user's side by letting the rocket launch and then cancelling the request before the next one launches, so I feel this is super low priority. Actually, this self-resolves when the rocket is launched, because that cancels the remaining request.

[LCStark]

Does this fake request still remain if you switch to remote view another surface? There's an issue with the Xs remaining on empty inventory slots on vehicles and that disappears after you've switched remote view to somewhere else and back again.

[Gorb]

There were times when I wanted to move tank shells from my tank inventory to my turret. Clicking on the tank shells sends them to storage somewhere else. If I try to cancel their delete order, I am unable to (which is different than everything else in Factorio). The stack of shells will be removed from the tank regardless of what I do. The only way to load the turret is to request new shells from storage. This feels like an unintended behaviour and doesn't feel good.

[LCStark]

There were times when I wanted to move tank shells from my tank inventory to my turret. Clicking on the tank shells sends them to storage somewhere else. If I try to cancel their delete order, I am unable to (which is different than everything else in Factorio). The stack of shells will be removed from the tank regardless of what I do. The only way to load the turret is to request new shells from storage. This feels like an unintended behaviour and doesn't feel good.

I think the biggest issue of handling those orders is the control scheme. We're accustomed to picking up / dropping items in the inventory with left-click, and shift-click moving to another inventory / trash.
But with remotely viewed inventories shift-click does nothing. And both left-click and right-click mark the item slot for removal, and only right-click cancels the order. It's confusing and it's easy to make mistakes, especially if you start quickly clicking things trying to stop the robots from taking out some stuff you didn't want them to take.

I think it would work better if by default left and right-clicking didn't do that (maybe leaving it to pickup a ghost of an item under the cursor on left-click?) and have it mark for removal after a shift-click, since that's what we normally use to trash the item anyway. It would be great to have a system like you imagined - "take this stack and move it to this inventory in another entity", but I think that might require more work than just a couple of quick fixes to the current system. Might be a good idea for you to post it in the Ideas and Suggestions subforum, though!

[Gorb]

I would agree that the controls feel unintuitive. I think a better design would be to allow a player to select items like they do with it in their hand and not have it do anything until it's told where to stick those items. I'd like right click to remove the items in the way that left click does now.

[Sachertorte]

I think the biggest issue of handling those orders is the control scheme. We're accustomed to picking up / dropping items in the inventory with left-click, and shift-click moving to another inventory / trash.

This isn't related to this bug report, but I'd be hard-pressed to tell someone what left and right clicking does in Factorio - it's all muscle memory. I appreciate that since 2.0, more things have had "Press X to do Y" listed in their hover tips. It'd be nice to standardise left/right clicking + shift/ctrl variations being listed in anything that supports that action - even middle clicking for inventory slot filters. That'd leave 'Right click to build the item in your hand' as the only implicit click (unless that's left click).

It helps that I have my hovered item info set to appear where my mouse cursor is, I probably wouldn't find this behaviour intuitive if it appeared under the minimap.

[Genhis]

Thanks for the report, this is fixed for the next release.