"EntityWithInventoryPrototype"

[BraveCaperCat]

Hi! I propose that a new prototype (likely abstract) be added called "EntityWithInventoryPrototype". It would be a simple entity prototype with an inventory. It would have some properties that ContainerPrototype has right now, such as inventory_size, inventory_type and quality_affects_inventory_size (mainly this one) and both ContainerPrototype and VehiclePrototype would inherit from it. VehiclePrototype would have an option to disable/enable the inventory, and you can work out what happens to the children prototypes of RollingStockPrototype.
The main reason for this request (for inventories to be separated from cargo wagons and containers) is so that CargoWagonPrototype can have the quality_affects_inventory_size property.

[Rseding91]

Why not just request that we add quality support for cargo wagons as a modding option? That would be *way* simpler than what you suggest

[BraveCaperCat]

Why not just request that we add quality support for cargo wagons as a modding option? That would be *way* simpler than what you suggest

Yes, but at least this way it's consistent with existing prototypes. (Looking at you, EntityWithHealth and EntityWithOwner Prototypes!)

[curiosity]

Why not just request that we add quality support for cargo wagons as a modding option? That would be *way* simpler than what you suggest

Why not then add it for every entity type with inventory? The end result would be indistinguishable.

[Rseding91]

Why not then add it for every entity type with inventory? The end result would be indistinguishable.

Because it takes developer time and energy to make tests for, implement, and then maintain it everywhere and there are currently 23 pages of bug reports to work on

[BraveCaperCat]

Why not then add it for every entity type with inventory? The end result would be indistinguishable.

Because it takes developer time and energy to make tests for, implement, and then maintain it everywhere and there are currently 23 pages of bug reports to work on

Which is better? An update fixing 20 bugs, or an update fixing 15 bugs as well as adding 1 (minor) feature?

[Bilka]

This was addressed by CargoWagonPrototype::quality_affects_inventory_size.