[boskid][2.0.39] Crash starting modded scenario (EntityToNameTagMapping check fails)

[the_gide]

What did you do?
I'm trying to load the game with a mod I created in version 1.1.

The "Base mod [2.0.39]" and "Factorio Bingo [1.5.0]" is loaded as the only 2 mods

I press Single Player -> New game -> Mod scenarios -> Factorio Bingo/Factorio Bingo -> Play
- Loading new map progress bar appears
- Game crashes with unexpected error

What happened?
Game crashes with unexpected error

What did you expect to happen instead?
Expected the game to load with the mod, or to get an error report within my lua files for the mods (since i'm kinda expecting that I need to update some of the code from 1.1.x to 2.0.x).

Does it happen always, once, or sometimes?
Yes, it always happend, tested both on Linux and Windows

Please let me know if there is any more information I can add.

[boskid]

Hm... the consistency check is correct as it detects "storage-tank1" and "storage-tankq" names both pointing at the same entity (storage-tank at position {2087.5, 1539.5}) while it was expected that entity may have at most one name associated with it.

[boskid]

Looks like the scenario that is provided by this mod already contains that storage tank with 2 names. I am going to move this to Not a bug - game is correctly detecting a corruption and i am unable to do any migrations here because i do not know which name should be kept and which one should be discarded. Entity should be only accessible under at most single name. Since this logic was reworked for 2.0, even if you would know the reproduction steps in 1.1 to cause single entity to have multiple names associated with it that would not help me at all. Simply saying: this bug report contains no details about any bug in the game, it only shows that you have a corrupted scenario and game has detected that the scenario is corrupted.

[the_gide]

Thanks for the insight.

I had figured out that it was related to the scenario map, since loading the mod on a 'normal' map did not break the code.

Yeah, the error did not occur in 1.1.x, I used the mod/scenario multiple times there. Hopefully I will be able to load the scenario in 1.1.x and fix the double name.
Might be the mod setting the name and the scenario having a name on the item already. Had some problems with that when designing the scenario / mod.

How did you see from the crash log that this was the problem? Just so I can figure these things out the in the future on my own
- Or did you do something else to find out about the "storage-tank1" naming problem?

[boskid]

How did you see from the crash log that this was the problem? Just so I can figure these things out the in the future on my own
- Or did you do something else to find out about the "storage-tank1" naming problem?

I loaded provided save file in factorio with debugger attached and saw the consistency check fail with all the values of variables it was using. This is not a step that you could do because that requires access to source code.