[2.0.43] When loading a save, attempts to load tmp file

[Radisovik]

I'm on an ARM mac mini-4. I usually run headless with autosave. However sometimes when I exit that server via a ^C and start up the game normally on the mac mini itself, and I tell it to just host the last auto-save, it gives me an error about a corrupt save file.

When I look at the file name, it is a version of the save file with a "tmp" within the name. Every time I try to load from the most recent save it keeps trying to load that same "tmp" file. If I delete the tmp file, the game loads just fine.

[Rseding91]

The tmp file indicates the process was killed while in the middle of saving the map during exiting.

Are you pressing the quit hotkey multiple times? The first one will attempt to save and exit gracefully. If you send a 2nd one while the first is not yet finished it will force terminate the process.

[Radisovik]

I could be hitting it twice.... the tmp file being around makes sense. However maybe on load, it should ignore the .tmp file?

[Rseding91]

The saving process is never meant to fail, so the loading logic was never designed to ignore failures to save - since saving should not be failing.

It feels wrong to change the loading logic to simple ignore that saving failed.