[2.0.55] Consistency Scraper drains UPS

Bugs that are actually features.
User avatar
Gerkiz
Long Handed Inserter
Long Handed Inserter
Posts: 70
Joined: Fri Nov 30, 2018 3:36 pm
Contact:

[2.0.55] Consistency Scraper drains UPS

Post by Gerkiz »

Hi,

Something in my scenario broke very bad, all of a sudden the game started to stutter very bad and consistency scraper was the one chugging the game.

Upon investigating the where the culprit was, I found a random spot in my map that most likely had some hidden entity(?).

Deleting whatever was there restored the UPS.



Attached the save also.

/Gerkiz
Attachments
bug02.zip
(5.11 MiB) Downloaded 19 times
b3FhJM.mp4
(3.83 MiB) Downloaded 16 times
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 3951
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.55] Consistency Scraper drains UPS

Post by boskid »

I am going to throw this to Not a bug:
1/ There exists an entity mtn-addon-electrical-stream (fluid stream) that spans from {44,-1336} up to {14839, 150}
2/ Because this entity is super long and at an angle, its axis aligned bounding box is huge, and it is found by the consistency scraper when visiting a lot of chunks
3/ Each time consistency is checked of this entity, all links between this entity and a surface are checked for consistency, that is about 5.5M links which is what makes this consistency check slow.
4/ It was found that this behavior depends on mtn-addon-electrical-stream having `target_initial_position_only` at default value (false) which makes it retarget to a character even when character is teleported which causes the issue.

there is nothing to change in 2/, i do not want to make 3/ skip entities because that would defeat the purpose of those checks, 1/ is caused by mod creating a fluid stream with flag missing and teleporting characters long distance within a single surface.

If there is anything to change, i would go with making target_initial_position_only have a default value of `true` but that could be a breaking change. Alternative change would be to make fluid stream stop tracking character past the teleport, but that is unrelated to this bug report as it is about consistency taking a long time.
Post Reply

Return to “Not a bug”