[2.0.68] C++ crash on checking state of a newly deployed space platform

Bugs which we just recently fixed in our development version and will reach you in the next release.
PyroGamer666
Inserter
Inserter
Posts: 29
Joined: Fri Aug 28, 2020 5:37 am
Contact:

[2.0.68] C++ crash on checking state of a newly deployed space platform

Post by PyroGamer666 »

I recently received the following bug report: https://github.com/nicholasgower/planet ... issues/308
Factorio & Muluna version number
Please post both the Factorio and Muluna version numbers here. If relevant post the version number of other mods used.

Factorio: 2.0.68
Muluna: 2.1.24

Cubium: 1.0.28
Cerys: 4.11.1
Maraxsis: 1.30.55
Moshine: 1.0.29

factorio-current.log

Describe the bug
A clear and concise description of what the bug is.

The game crashes whenever I attempt to create a new space platform from Muluna, but only when the placed telescope has its internal combinator turned on.

To Reproduce
Set up a save with a telescope on Muluna, and turn on its combinator.
Set up a rocket silo with the ability to launch Space Platform Starter Packs.
Try to create a new space platform from Muluna.
Wait for the corresponding rocket silo to launch the pack.
Game should crash.

Expected behavior
I expected the launch to work successfully and the platform to be created.

Screenshots
N/A

Additional context

This telescope was the only one placed anywhere in the save file so far
The telescope (and thus the underlying combinator as well) was Uncommon Quality, and contained some speed modules. I expect the latter is irrelevant, and the former feels like it should also be irrelevant but including just in case.
Launching a platform with the combinator turned off worked fine, so it's specifically when the combinator is enabled that the problem occurs. There's no need to attach the combinator to any other entities via circuit wire, though at an earlier point in the save I had done so (and later removed it).

Save file & log
Log attached; save file too large and GitHub repeatedly refused to attach it

On further investigation, I reproduced the issue and narrowed down the issue to checking the state field of a newly created space platform causing the crash. Since this is a C++ crash, I will consider this issue fixed if the crash is either resolved or replaced with an error in Lua.

To reproduce:
Clone this debug branch of Muluna. Download all of the required dependencies from the mod portal. https://github.com/nicholasgower/planet ... rash-debug

Load the attached save. The save contains a rocket silo with a space platform starter pack. Attempt to create a new space platform from this starter pack. The game will crash after entering the platform's name.

For your reference, the relevant block of Muluna code begins here: https://github.com/nicholasgower/planet ... s.lua#L263
Attachments
factorio-current.log
(153.97 KiB) Downloaded 13 times
telescope crash test.zip
(10.85 MiB) Downloaded 10 times
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4189
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.68] C++ crash on checking state of a newly deployed space platform

Post by boskid »

Thanks for the report. I already noticed this crash about 20 minutes ago through automatic crash reports and was able to reproduce it just from the crash log. Issue is fixed for 2.0.69.
Post Reply

Return to “Resolved for the next release”