[2.0.32] Ctrl-click on train stop to add as temp stop adds misaligned locations

[terronium]

Usecase
In the Locomotive Remote view (train view) we can add temp stops by ctrl+click on either a location on rail track or on train stops. Train stops show up as a circle with a thick black outline. If you hover over the train stop in that view, zoomed out enough to have blocky map view, you see a yellow square around the circle signifying the stop as the click target.

When you ctrl+hover over the rail track it draws a while-green line telling the path and where the train would stop if that temp stop is added. But when you hover over the train stop circle, within the yellow square, the line disappears. I assume that indicates that the stop location would be added at the temp stop and you dont need the line to see the exact stopping location.

Issue
Depending upon where you ctrl-click in the yellow square when hovering over the train stop target, the actual location added can be different by a few units. This is causing trains to stop at the stop misaligned with the stop and the inserters for the wagons get misaligned. Its hard for me to capture the click location in the attached screenshot as the mouse pointer disappears but both the temp stops are added by clicking in the yellow square of the same stop just in different location within the square. Hopefully you can see that in the logs/savefile. As you can see in the screenshot the red line indications the path of the train, the train would stop ahead of the stop.

Depending upon the location of the stop and the orientation, and the click location, I have seen the train stopping both too early and too ahead of the stop, misaligning the wagon inserters.

Expected behavior
If the temp stop is added by ctrl+click on a train stop, wherever in the yellow square target, the temp stop location should be added such that the train stops correctly aligned with the stop.

Based on experience, this was not an issue in 1.0 and likely a regression after 1.0. But I my 1.0 memory is mostly modded so cant be 100% sure. Regression or not, I think the bug / improvement-request stands.


Screenshot

Screenshot 2025-01-23 211204.png (573.75 KiB) Viewed 643 times

[Rseding91]

Thanks for the report. Looking into it: ctrl + click on a train stop is not a real thing that has ever existed. It's always "add temp stop based off the rail clicked". The highlighting when moussing over a train stop simply attempts to draw all trains that are pathing to that stop and so it also stops rendering the temporary path logic.

I'm open to suggestions for how to do the rendering differently but as far as I can tell this is all working as intended.

[terronium]

Apologies for a very delayed reply. My recommendation

- Ideal version - since there is a square drawn around the trail stop, the user understands that the location of the train stop is being added as the temp stop. so if the user is ctrl-clicking on the train stop square the no matter where in the square the user clicks, always add the stop's location as the temp stop and not the underlying rail that might a unit away causing inserters to misalign. Even though internally the ctrl-click on the stop may not exist as a usecase, the rendering of the square around the stop and specially the hiding the white-green line. show that to be a distinct behavior and thus usecase. Hiding of the white-green line is understood by the user (atleast me and probably generally) that i dont have to do the precise rail alignment of the line anymore and it would be the stop location that would take care of the rail alignment.

- alternate version - remove the UI behavior of "the rendering of the square around the stop and hiding the white-green line" so its a clear signal to the user that the train stop ctrl-click is truly not a thing you always have the white-green line to visualize where the temp stop would be. No square ot click target on the stop. This would put the onus on the user to get the rail correct for the correct alignment. A bit more tedious for the user but atleast the white-green line would not be hidden so the user can do the alignment.