[0.7.0] Crash when pressing shift + spacebar

[FreeER]

windows x64 installation version of Factorio (build 6571)
Noticed this when I placed fish in the last hotbar slot (shift+5). I'd be shooting and then try to use fish and heal, and sometimes I'd crash. Did a quick test and it seems sometimes I didn't lift off of the shift key before I went back to shooting and when I hit the spacebar to shoot Factorio would crash. Quick work around of course is to move the fish/consumables to one of the first five slots or make sure to not hold shift but still a somewhat interesting (and annoyingly timed) crash.

[Nirahiel]

It's because Shift+Space is meant to pause the game, and I think the game is trying to pause then heal you and shoot at the same time and since you can't heal or shoot when the game is paused, it crashes.

[slpwnd]

Thanks for the report. This will be fixed in 0.7.1. Nirahiel is sort of right. The cause of the crash was that shift + space paused the game while the progress bars on capsules in the hotbars were still running. And then some internal state would go wrong. Comment from the code:

Code: Select all

 // game view is not updated intentionally to keep the regular (character) view
 // TODO this could potentially cause some errors if those guis are calling
 // controller methods via the player interface

[Nirahiel]

Nirahiel is sort of right.

Yeah I know
If only I could have access to more than just the LUA scripts

[FreeER]

Comment from the code:

Code: Select all

 // game view is not updated intentionally to keep the regular (character) view
 // TODO this could potentially cause some errors if those guis are calling
 // controller methods via the player interface

LOL

I know

lol, I'd forgotten about shift+space being used to pause the game (I always use Esc) so my guess was some error with hitting shift causing it to expect a number and somehow the space slipped through error checking, even though that seemed unlikely.

If only I could have access to more than just the LUA scripts

I wouldn't mind that either, admittedly it'd be more of a learning experience for me (I've only recently gotten around to learning Java and C/C++, and the basics of asm) I'll continue to hope that eventually the source will be released for those who would like to see it (even if it's only to those who are trusted not to upload it elsewhere) xD

[slpwnd]

I'll continue to hope that eventually the source will be released for those who would like to see it (even if it's only to those who are trusted not to upload it elsewhere) xD

We have agreed with kovarex to do this at some point in the (not so far) future.

[FreeER]

We have agreed with kovarex to do this at some point in the (not so far) future.

news to me so, YAY