[2.0.69] Pipe to ground with 2 aboveground connections is not flippable in certain orientations

[protocol_1903]

Reference: https://mods.factorio.com/mod/the-one-m ... 2cbd51b1f7

I replace pipe to ground underground connections with an aboveground connection. For whatever reason, that breaks flipping in certain orientations, and when in blueprints they will be flipped correctly sometimes, and other times their orientation will not change. This is seemingly random.

I'll be migrating to using storage tanks to fix another non-bug issue, but thought this was worth reporting as it may effect other custom ptg mods.

[boskid]

I suspect the issue is caused by the flipping logic comparing connections using only direction(transformed) + offset(transformed) + connection_type + flow_direction + max_underground_distance, but ignoring other parameters like connection_categories or underground_collision_mask, and as such it incorrectly deduces that both pipe connections are the same and it does not need to change direction when flipping. Do you have a save that i could sync mods with and play around to verify if thats the real cause?

[protocol_1903]

I figured it would be something along those lines. That might be something to note on the documentation about flipping requirements if that ever gets added.

Just updated the mod on the portal and confirmed that the issue still exists.

Some things to note about flipping when just the entity is in the cursor:
- when flipping either direction when entity is north, nothing happens
- when flipping either direction when entity is south, entity is flipped to north
- when flipping either direction when entity is east, nothing happens
- when flipping either direction when entity is west, entity is flipped to east

[boskid]

Thanks for the report. Issue is now fixed for the next release. Flipping logic was incorrectly computing flip transformations due to missing check of pipe connection categories making it consider related pipe connections as equal.