[2.0.73] Inserter direction in graphics definitions are backwards

[Osmo]

An inserter is modified like this:

Code: Select all

local inserter = data.raw.inserter.inserter
inserter.platform_picture = {
    north = {
        filename = "__core__/graphics/arrows/hint-orange-arrow-up.png",
        size = {62,37},
    },
    east = {
        filename = "__core__/graphics/arrows/hint-orange-arrow-right.png",
        size = {38,73},
    },
    south = {
        filename = "__core__/graphics/arrows/hint-orange-arrow-down.png",
        size = {71,35},
    },
    west = {
        filename = "__core__/graphics/arrows/hint-orange-arrow-left.png",
        size = {43,73},
    },
}

Clearly, north is up, east is right, south is down and west is left
However what actually happens is that an inserter in north direction renders down arrow, and other directions are wrong as well:
north is down, east is left, south is up and west is right.

Inserters from left to right facing: north, east, south, west

изображение.png (768.09 KiB) Viewed 459 times

[eugenekay]

It appears to be referring to the Direction it is pulling FROM; not the one it is pushing TO.

[Osmo]

It appears to be referring to the Direction it is pulling FROM; not the one it is pushing TO.

The direction its pulling from can be changed.
What's the main point is that the graphic definition doesn't match entity direction (as can be seen in the debug tooltip)

[Klonan]

There may or may not be some error in the naming, but that is why the direction in the game is not dependant on the naming of the sprite files or vice versa

i.e, this is not a bug

[Osmo]

There may or may not be some error in the naming, but that is why the direction in the game is not dependant on the naming of the sprite files or vice versa

i.e, this is not a bug

I don't understand how an error in the naming is not a bug. Its not a typo, the meaning is backwards. I do understand how this is can be a minor issue or a won't fix, but it is clearly wrong

[boskid]

Well, inserter takes sprites from `platform_picture` using opposide direction than the entity's direction. Removing this code is possible but that change would not cause anything impossible to become possible, it would be just a change for the sake of changing it and all mods with their own versions of inserter sprites would have to adjust to the change. I would rather keep existing behavior since it is not broken, just not fully described.

[Osmo]

Understandable, thanks for the response