[2.0.75] Rail Planner Not Starting On Elevated Rails Most of the Time

[Tesseractcubed]

What happened:
Attempting to start a ghost elevated rail or elevated rail from any elevated rail element that isn't the high end of the ramps results in an X. Pressing the change rail layer button doesn't change the result. Video of issue attached.
Issue is repeatable*** and persists across different saves, but only on one particular installation of the game (does not occur on other installation); it also didn't happen a couple times, but the majority of the time the bug existed. I now heavily suspect an issue with the files with the one particular install, which is also responsible for viewtopic.php?t=132351. That being said, I haven't edited or adjusted the internal files. :/

Detailed comparison of the two installations show no obvious differences between the two installations (checksums are the same, path names don't have restrictions, folders take up the same amount of space, etc.)

Expected result:
The rail planner would be able to start a ghost rail in the middle of any section of elevated rail.

BugReportRailPlannerElevatedRails2-0-75.mp4

(46.43 MiB) Downloaded 223 times

I'll call this another 1/0 that isn't reproducible, but let me run more tests (seeing if a portable copy of the buggy installation running on a flash drive yields the same results, etc.), and then possibly looking at getting the bug reproduced on another machine.

[boskid]

Could you attach the "cubedlowdensitystructure" mod from the faulty instance? It is not present on mod portal and i suspect it may be messing with the rail item while not messing with the ramp item. Rail planner to work needs to be told what entities can be placed and this is decided by the held rail planner item, and here it looks that when you are holding a ramp item (a rail planner) it works but when holding a rail item (also a rali planner) it does not work.

-- edit:

Since all 2 cases "with bug" have this mod enabled while 2 "no bug" cases are unmodded, i am going to claim this is mod issue and as such Not (our) bug. However i still want to take a look at this mod to know why it is broken.

[Tesseractcubed]

Attached is two of the cubedlowdensitystructure.zip files (I attempted to trim down empty folders with the second one), and a link to the github repositoryhttps://github.com/Tesseractcubed/cubed ... /tree/main. It's just two lines in data.updates... The issue is occuring with either of these two files.
But the issue goes away without the mod, so it looks like you're correct. I didn't seriously consider that it was a mod issue due to the relatively small size of the mods.

Thanks for your time

Edit: The mod seems to cause the same issue on the other instances.

[boskid]

Given this part of the log:

Code: Select all

   ...
   1.784 Loading mod base 2.0.75 (data.lua)
   1.958 Loading mod elevated-rails 2.0.73 (data.lua)
   ...
   2.403 Loading mod cubedlowdensitystructure 0.0.1 (data-updates.lua)
   2.433 Loading mod cubedlowdensitystructure 0.0.1 (data-final-fixes.lua)

and this content of `data-updates.lua`:

Code: Select all

require("__base__.prototypes.item")
data.raw.item["low-density-structure"].stack_size = 10

Its almost certain that the first line of code here is the culprit: when __base__.prototypes.item gets included and processed, it overwrites existing prototypes (including "rail" item that was already adjusted by elevated-rails mod) with a vanilla rail item which means rail item no longer can place elevated rails (this data was added by elevated-rails data, but got reverted).

The only super suspicious part here is why was this file included for the second time, given that "require" should not execute file for the second time when it was already processed.

[Tesseractcubed]

Thanks very much... now to go use a different method.

[boskid]

`require` doing a repeated include is now fixed for 2.1. In case of your mod there is no need to require("__base__.prototypes.item") (all prototypes from base mod should be already inside of data.raw) so by removing that line your mod should be also fixed.