[2.0.76] Toggling silo LuaLogisticPoint.enabled can break rocket logistics and hang factorio

[Hexcoder]

Toggling LuaLogisticPoint.enabled on a space age rocket-silo while silo is getting items delivered can break it permanently and then cause following game saving to hang and save loads to crash

Reproducible with all other mods disabled, on a modded but "clean" save (a save before I messed around with mod development)

Steps to reproduce:
-load megaSA12_bug2.zip
A platform in orbit is currently requesting calcite, a silo is being delivered calcite via automatic request
-Open Rocket Silo GUI on the lower silo
-Rapidly toggle Provider Enable and Requester Enable in the "Silo control" modded relative GUI to the right
this will toggle "enabled" on first and second logistics points on the silo from lua
I believe it has to be toggled _while_ the silo is still having items delivered, not while it is idle!
-This may then break the rocket silo to where it does no longer auto launch despite being full
or sometimes enter a state where the silo is being chaotically loaded and unloaded at the same time to and from the nearby buffer chest
-Sometimes the next or one after the next autosave will hang completely at 0%
If trying to load a save before this, the game can crash, log included

Note that I could not reproduce it 100% of the time. May require re-trying 2-3 times. (Try loading as in step 1, if it does not crash, repeat process)

What did you expect to happen instead?
I assume a crash is of interest either way.

That said, this usage of the API for the silo may not be supported, the goal of my mod is to allow more detailed control of rocket logistics.
(launch_rocket() API allows launching via circuit condition, but automatic logistics of silos can defeat the point, so ideally could be disabled at will.)

A modder may however expect that the all logistics points of the silo can safely be modified at any time, and work as expected.
-disable requester point and possibly edit filters (though engine might overwrite)
-disable passive provider but that may not be supported by the engine (?)

[boskid]

I remember seeing something slightly similar (131263) but i am not sure i can decide if its the same issue or a different one.

[Rseding91]

Can you provide the save file that crashes when loaded?

[Hexcoder]

Sorry, to be clearer:
I can get the silo into a weird state most of the time, but this does not guarantee the crash. Note that it really seems to require spamming of the checkboxes.
However after about 2-5 retries I can get it to crash.
I tried, but I believe I can't produce a savefile that crashes on load or without additional player interaction because it either:
will hang forever when saving with progress at 0% (saving manually or autosaves) (see screenshot)
or when trying to load a different save while still in game it will crash instead

hung_on_save.PNG (3.34 MiB) Viewed 171 times

megaSA12_bug_buffer_chest_weirdness.zip:
I've attached this save, where I could not produce the crash but captured weird behavior that may be related.
The bots are unloading items directly from the main inventory (not trash) into the buffer chest and then back into the inventory, or is that expected with this API?

[Rseding91]

I was not able to reproduce the freeze-on-save but I did find several issues with script-disabling rocket silo provider points connected to orbital logistics. After fixing them on the engine side and testing the reproduction steps everything seems to work as expected.

[Hexcoder]

Thanks a bunch.

Let me know if there's any more information I can give. Only think that comes to mind is automating the toggling + saving and letting it run.
Gives me memory corruption vibes with how it acts.